Aces High Bulletin Board

General Forums => Custom Skins => Topic started by: Skuzzy on June 12, 2018, 09:36:22 AM

Title: Beta Test of new skin admin system.
Post by: Skuzzy on June 12, 2018, 09:36:22 AM
We are doing an update to the skin administration site and during the test phase any and all changes made will be completely obliterated when we go live with the new system.  The current active system is disabled until we get through the Beta testing for the new site.

Even registering as a skinner will be wiped out.

The update for the site added more administration tools for HTC to use, but also added an option to allow skinners an easy way to adopt skins.  Several small bugs/inconsistencies were also addressed.

There is quite a bit of debug output in the adoption section.  If you run into an error we need the complete copy of the debug output along with any error output.  It is all text, so a simply copy and paste will suffice. 

Posting it in this thread will be fine.
Title: Re: Beta Test of new skin admin system.
Post by: Vraciu on June 12, 2018, 09:51:21 AM
The Adopt a Skin link takes me to a spot that shows the skins I’ve adopted.  No orphans are shown. 
Title: Re: Beta Test of new skin admin system.
Post by: DubiousKB on June 12, 2018, 10:12:40 AM
Huzzah for the skinners? 

Keep giving the comunity better tools to enhance the game!  :salute

(celebrate the little victories or you'll go crazy) :rock
Title: Re: Beta Test of new skin admin system.
Post by: Skuzzy on June 12, 2018, 10:46:51 AM
Ok, give it a go again.
Title: Re: Beta Test of new skin admin system.
Post by: Vraciu on June 12, 2018, 10:50:07 AM
Ok, give it a go again.

That fixed it.

It says I adopted the skin I selected.   Now let me try and update it. 
Title: Re: Beta Test of new skin admin system.
Post by: Skuzzy on June 12, 2018, 10:52:11 AM
Like I said, you can do whatever you want.  It will all be undone when we go live.
Title: Re: Beta Test of new skin admin system.
Post by: Vraciu on June 12, 2018, 10:55:19 AM
Like I said, you can do whatever you want.  It will all be undone when we go live.

Understood.  I will just pretend to go through the entire process in case we have a bug. 
Title: Re: Beta Test of new skin admin system.
Post by: Skuzzy on June 12, 2018, 10:58:21 AM
Caught a bug in your adoption.  Fixed it.

The word "by" in the name of the skin was not lower case, as I assumed it was.  So the name of the skin had your name appended, instead of replacing "rogerdee".
Title: Re: Beta Test of new skin admin system.
Post by: Skuzzy on June 12, 2018, 11:01:14 AM
Found another bug.  Going to require starting the test over.  Give me a minute.
Title: Re: Beta Test of new skin admin system.
Post by: Skuzzy on June 12, 2018, 11:07:52 AM
Ok, live again.  Try the adoption again.
Title: Re: Beta Test of new skin admin system.
Post by: Vraciu on June 12, 2018, 11:19:46 AM
Ok, live again.  Try the adoption again.

Will do.  Man you are fast.   :x
Title: Re: Beta Test of new skin admin system.
Post by: Vraciu on June 12, 2018, 11:20:45 AM
Directory Read Error
p51b_10 open failed

Title: Re: Beta Test of new skin admin system.
Post by: Skuzzy on June 12, 2018, 11:36:55 AM
EDIT:  I found it.  Forgot to restore from the previous adoption when I reset the databases.
Title: Re: Beta Test of new skin admin system.
Post by: Vraciu on June 12, 2018, 11:40:12 AM
Did you reload/restart/refresh your browser after I reset the databases?

Affirmative.  Just did so again to be sure.  Same error. 
Title: Re: Beta Test of new skin admin system.
Post by: Skuzzy on June 12, 2018, 11:41:55 AM
Try it now.
Title: Re: Beta Test of new skin admin system.
Post by: Vraciu on June 12, 2018, 11:57:59 AM
Adoption went through.  Skin assigned.   Click on it under management page...


Skin Information
http://www.325thfg.org/
http://www.web-birds.com/15th/325/325th.htm



Directory Read Error
p51b_10 open failed
Title: Re: Beta Test of new skin admin system.
Post by: oboe on June 12, 2018, 12:22:31 PM
- I was able to select and adopt a skin (a P-39D by Rogerdee), I got to the Congratulations on your adoption page.   

- When I went back to main skins admin page, it shows only 8 released skins for Oboe, all P-38Gs.   I should have P-39Qs, P-38Js and Ls, P-51Bs and a P-51D.

- clicking on any of the 8 skins shown, it displays a bunch of php source code.

Logged out and logged back in again, still shows only 8 skins, all P-38Gs for oboe.

EDIT:  tried to submit a new skin, but it was for P-51D and I got the message showing all skins full. When I backed out of this, all my skins were showing again.
Title: Re: Beta Test of new skin admin system.
Post by: Skuzzy on June 12, 2018, 12:24:43 PM
Adoption went through.  Skin assigned.   Click on it under management page...


Skin Information
http://www.325thfg.org/
http://www.web-birds.com/15th/325/325th.htm



Directory Read Error
p51b_10 open failed


- I was able to select and adopt a skin (a P-39D by Rogerdee), I got to the Congratulations on your adoption page.   

- When I went back to main skins admin page, it shows only 8 released skins for Oboe, all P-38Gs.   I should have P-39Qs, P-38Js and Ls, P-51Bs and a P-51D.

- clicking on any of the 8 skins shown, it displays a bunch of php source code.

Fixed.  An adopted skin cannot be viewed until the update has been submitted.  Has to do with the skin actually still released, but being updated.  It is a rather complicated mess as it has to be moved out of the normal path of things so we know it is being updated.

We have to update two other databases manually, when a skin gets adopted, in order to be able to track it.

This is the best I can do for right now.

Oboe, you were working while I was making changes.  I am doing this live.
Title: Re: Beta Test of new skin admin system.
Post by: Skuzzy on June 12, 2018, 12:25:07 PM
Something is still amiss.

Give me a minute.
Title: Re: Beta Test of new skin admin system.
Post by: oboe on June 12, 2018, 12:31:08 PM
oh, sorry.  let me know when  clear to test again...
Title: Re: Beta Test of new skin admin system.
Post by: Vraciu on June 12, 2018, 12:33:13 PM
Fixed.  An adopted skin cannot be viewed until the update has been submitted.  Has to do with the skin actually still released, but being updated.  It is a rather complicated mess as it has to be moved out of the normal path of things so we know it is being updated.

We have to update two other databases manually, when a skin gets adopted, in order to be able to track it.

This is the best I can do for right now.

Oboe, you were working while I was making changes.  I am doing this live.

Okay.  So how can we view the original bitmap?  I like to have these to look for clues.   I’m guessing if we don’t save them before we adopt them we lose the ability to view them. 
Title: Re: Beta Test of new skin admin system.
Post by: Skuzzy on June 12, 2018, 12:43:02 PM
Ok, I think I have gotten things worked out where you can view the adopted skin from your front page.

Everything should be good to go now.
Title: Re: Beta Test of new skin admin system.
Post by: Vraciu on June 12, 2018, 12:43:17 PM
Whatever you just did fixed it.  I can see the original BMP now.  Nice job, Skuzzy. 

 :aok

Now to try an update.
Title: Re: Beta Test of new skin admin system.
Post by: Devil 505 on June 12, 2018, 01:09:23 PM
Adopted a 190A-5 skin without issue.  :aok
Title: Re: Beta Test of new skin admin system.
Post by: Vraciu on June 12, 2018, 01:18:53 PM

I had a file named incorrectly and got stuck in a loop during the upload--never returned an error, just gave me the eternal circle of motion.   Fixed that issue when I noticed and it worked out just fine.  All files validated (I submitted every single one as a test).


Welcome to the skin update validation page.
Basic Skin Information
Object Name    p51b
Skin Name    325FG/318FS By Vraciu
Skin Reference    P51B8101605
Submission Update Status
File    Name/Data
Verified    Type    Size    Color
Depth    File
Format
dude1.bmp                
dude2.bmp                
fullsizeimg.jpg             N/A    
reference1img.jpg             N/A    
reference2img.jpg             N/A    
thumbnailimg.jpg             N/A    
p51b.bmp                
p51b_e.bmp                
p51b_n.bmp                
p51b_p.bmp                
p51b_s.bmp                

Congratulations! Your skin updates have been accepted for review!
Title: Re: Beta Test of new skin admin system.
Post by: Skuzzy on June 12, 2018, 01:22:13 PM
Which file was named incorrectly?
Title: Re: Beta Test of new skin admin system.
Post by: Vraciu on June 12, 2018, 01:25:42 PM
Which file was named incorrectly?

I believe it was reference1img.jpg -  I had it named as "reference1img - Copy.jpg" instead.

It worked right with the proper name.

I then went and did the entire process again with a second skin and it worked fine.  No misnamed files.  :rofl   Heh.
Title: Re: Beta Test of new skin admin system.
Post by: Skuzzy on June 12, 2018, 01:31:12 PM
I'll check the error handling for that.  There is a window where I cannot post an error back to the client.
Title: Re: Beta Test of new skin admin system.
Post by: Vraciu on June 12, 2018, 01:35:04 PM
I'll check the error handling for that.  There is a window where I cannot post an error back to the client.

You want me to screw it up again on purpose and see what it does?
Title: Re: Beta Test of new skin admin system.
Post by: Skuzzy on June 12, 2018, 01:44:39 PM
I should be able to duplicate that.
Title: Re: Beta Test of new skin admin system.
Post by: Vraciu on June 12, 2018, 02:02:08 PM
I should be able to duplicate that.

Gotcha.  Shoot me a PM if you need me to try anything else.  I'll be checking back here regularly in any case.  Good work.  I like the system you have going.  Very slick.   :cheers:
Title: Re: Beta Test of new skin admin system.
Post by: Skuzzy on June 12, 2018, 02:19:35 PM
I figure to take it live Thursday (June 14) morning, if all goes well.

I may update some things as I have a long list of things to do for the site.
Title: Re: Beta Test of new skin admin system.
Post by: oboe on June 12, 2018, 02:30:30 PM
OK everything is looking good from my end - I was able to adopt one and only one skin, submit a new skin, and update one of my existing skins.

Is there anything else you'd specifically like us to try doing?

Title: Re: Beta Test of new skin admin system.
Post by: Skuzzy on June 12, 2018, 02:38:45 PM
That is pretty much it oboe.  I may switch it live tomorrow.  Just depends on how it all looks on my side.  I have to go through the database and make sure everything is as it should be.  Then clean up the debug output.
Title: Re: Beta Test of new skin admin system.
Post by: oboe on June 12, 2018, 04:48:05 PM
Congrats, it seems to work really slick.   

One thing I noticed, which I wouldn't call a bug per se, but there seemed to be two different formats to the file selection/submission panel.  One version split the files into Required and Optional groups, the other just listed all the files alphabetically by filename.

I preferred the split of files into two groups rather than showing in a single large group; it might make sense to have the map files (diffuse, spec, normal, etc) in one group and the supporting files (fullsizeimg, thumbnail, reference1 and reference2) split into a second section.   I think it was a bit easier to use with a little white space in the design, but not a big
deal.     


Title: Re: Beta Test of new skin admin system.
Post by: Skuzzy on June 13, 2018, 06:00:55 AM
The update page is the new standard.  Going to be switching the submission page to that look.

It is one of many things to do.
Title: Re: Beta Test of new skin admin system.
Post by: oboe on June 13, 2018, 08:14:26 AM
Just wanted to say I really appreciate all the streamlining you've done with skins.  Its so much better and faster now, in so many ways.   

The skin information pages look great and new skins get into the game so much faster than they used to.  And you given us a way to update many of the older, lower quality skins.

Thank you for all that effort, Skuzzy.  <S>
Title: Re: Beta Test of new skin admin system.
Post by: Vraciu on June 13, 2018, 08:59:19 AM
+1
Title: Re: Beta Test of new skin admin system.
Post by: oboe on June 13, 2018, 09:23:55 AM
I just ran into a slight problem with the new system.   I can't see the orphaned skins listing anymore.

I *think* all the orphaned skins were formerly shown on the our Skinner Information page - first it listed submitted skins, then it showed all my skins, and after that it used to show all orphaned skins.   It no longer shows the orphaned skins.   

When I click on "Adopt a skin" it gives me an error/warning message stating I have already adopted a skin.  This is a correct message, but I think skinners who have adopted a skin should still have a way to see all the orphaned skins available, for planning purposes.   I think it would be better if clicking on "Adopt a skin" still took you to the orphaned skins listing, even if you have adopted already.   The error message "You already have an adopted skin" could be invoked if you try to select an individual skin on this page, if you've already adopted.   
 
Title: Re: Beta Test of new skin admin system.
Post by: Skuzzy on June 13, 2018, 09:25:37 AM
You have a knack of hitting the pages while I am updating.

I just took the site live.  Use http://bbs.hitechcreations.com/skinadmin now.
Title: Re: Beta Test of new skin admin system.
Post by: Vraciu on June 13, 2018, 09:52:34 AM
You have a knack of hitting the pages while I am updating.

I just took the site live.  Use http://bbs.hitechcreations.com/skinadmin now.

Cool!   Nice job, bruh.  I just adopted one.   This is slick.   :banana:
Title: Re: Beta Test of new skin admin system.
Post by: oboe on June 13, 2018, 11:18:42 AM
You have a knack of hitting the pages while I am updating.

I just took the site live.  Use http://bbs.hitechcreations.com/skinadmin now.

Sorry, must be a gift.  I can see all the orphaned skins available now when I click "adopt a skin", however I assume its because the test data has been cleaned out and I don't have any active adopted skins.
Title: Re: Beta Test of new skin admin system.
Post by: Greebo on June 13, 2018, 11:51:17 AM
I just adopted a skin successfully as well.
Title: Re: Beta Test of new skin admin system.
Post by: Skuzzy on June 13, 2018, 12:03:41 PM
Sorry, must be a gift.  I can see all the orphaned skins available now when I click "adopt a skin", however I assume its because the test data has been cleaned out and I don't have any active adopted skins.

That is correct.
Title: Re: Beta Test of new skin admin system.
Post by: Skuzzy on June 14, 2018, 09:54:58 AM
Updated the skin submission page to match the skin update page and how it breaks the required from the optional files.  This has been consolidated into one function now.

Added code to log errors into a file in those instances where we should never get an error.  Tracking down why we occasionally get a file open error.

Made a change to the update code to take into account a skin being updated was just adopted.  Update had to be able to find the adopted skin and could not do so.

Updated version from 4.0.1 to 4.0.2

It is live.