OK, in my experience:
IF you have the bucks (it takes ~$650 to get into the game with the cheapest Goodone smoker), THIS is the brand I'd get.
Goodone - The Ultimate in Smoking IF you do a LOT of smoking for large crowds, it's worth it. They are well made, work amazingly well and have the "water pan" option which I like.
But they are pricey.
If you are just cooking for the family and on a budget, you can make AMAZINGLY good BBQ with the famous "El Cheapo Brinkmann". In fact, some folks have won various categories at the Jack Daniel's Nationals using the Brinkmann.
You can get the basic one for $25 and "tune it up" for about another $10 using the ideas on this site:
Brinkmann Smoke & Grill
Or you can buy the one Brinkmann "updated" after they realized a lot of folks were improving their basic model. This will set you back about $45 and has most of the "good stuff" from the ECB tune-up site already incorporated.
Me? I use the old $25 Brinkmann with the tune-up. No complaints from many satisfied diners.