ghi I think you're correct that "something isn't right", but for the vast majority of us the most useful approach is to simply follow common-sense rules.
Have an emergency fund.
Don't have any debt except maybe a mortgage, and pay that off as quickly as possible.
Have a budget so you know EXACTLY where your money goes and so you can pay cash for everything.
As part of your budget, put 15% of your income into retirement, preferably ones with tax benefits like roth IRAs, taking max advantage of company matching contributions if offered.
Fund out of your budget, in advance, any big expenses you expect to have, and then pay cash. Like cars, kids college, down payment on a house, luxuries like a boat, etc.
Carry level fixed rate term life insurance for 10x your salary, as long as there are people depending on your salary. Insurance isn't an investment and it isn't for YOU, its for the people you leave behind and they don't need an investment they need a payout to replace your lost income.
Follow these simple guidelines and even low-income families can have a HUGE amount of money to retire on or pass to their kids as an inheritance. Instead, people get caught up in the moment and buy luxuries on credit, prioritize their cable tv over retirement investments, and point at big picture things that simply don't apply as an excuse why they refuse to save or live within their means. I'm sorry, 17 trillion bucks in national debt has absolutely nothing to do with my decision to buy or not buy a widescreen tv. Justifying buying luxuries or not saving on the federal debt is self deception, using that to justify irresponsible personal behavior. Sorry, if you have a new car loan and a new tv, you have no reason to complain about the federal debt. Instead of blaming the govt stupidity for my own financial decisions, I have 2 6-yr-old cars that were bought with cash and they won't be replaced until I can pay cash. If they die and I need a replacement before I can afford a nice new car, then I'll buy an ok used car instead of following the irresponsible example set by both our government and by other citizens, neighbors and friends, who have become accustomed to spending more than they make while blaming their finances on everyone else.
If the economy crashes, are you going to be better off with or without debts owed to others? When things get tough you can bet those debts will be called in because the lenders will be desperate. Far better off to survive any coming crash if you don't owe anything to anyone, even if your investments lose value in the crash. Having half of your investment value and no debt is a far better situation than having half of zero savings while retaining all the debt...
On insurance... Remember this - When you invest and expect a return on investment higher than a savings account interest rate, you MUST accept some risk. That's how it works, nobody pays you back if you don't risk your money. The purpose of insurance is the exact opposite, to spend a little money transferring risk to someone else. So why would you buy an insurance policy as an investment (whole life for example), when we KNOW that you don't get any real return unless you're the one accepting the risk? Expecting great results from a whole life policy is like pouring half a cup of water into another cup and expecting it to magically increase just because you moved it to another cup. Its far better to pay a mere fraction of the insurance premium for level term insurance to transfer risk to the insurance company *only while you have dependents who need your income*, and use the rest of your investment money in a real investment that will get you a better return in exchange for the risk you are accepting for those investments.